aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 28411: Adding quota check into replaceCronTemplate rpc.
Date Thu, 27 Nov 2014 00:36:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28411/
-----------------------------------------------------------

(Updated Nov. 27, 2014, 12:36 a.m.)


Review request for Aurora and Bill Farner.


Changes
-------

Rebased.


Bugs: AURORA-946
    https://issues.apache.org/jira/browse/AURORA-946


Repository: aurora


Description
-------

Merged scheduleCronJob and replaceCronTemplate implementations. 


Diffs (updated)
-----

  api/src/main/thrift/org/apache/aurora/gen/api.thrift b91fca9383891af15477a6f6ef7c407bfa125303

  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9087eb2a5b305ceb1c5d50c75b9ca2ea2143a10f

  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java c602b304fc7d8abbcf397f30dd364d6aa1b4de9b


Diff: https://reviews.apache.org/r/28411/diff/


Testing
-------

./gradlew -Pq build

vagrant@vagrant-ubuntu-trusty-64:~$ aurora update  devcluster/vagrant/test/cron_hello_world2
aurora/examples/jobs/cron_hello_world.aurora 
WARNING: update is an aurora clientv1 command which will be deprecated soon
To run this command using clientv2, use 'aurora job update devcluster/vagrant/test/cron_hello_world2
aurora/examples/jobs/cron_hello_world.aurora --health-check-interval-seconds=3'
 INFO] Updating job: cron_hello_world2
 INFO] Response from scheduler: ERROR (message: Aborting update without rollback! Fatal error:
Response from scheduler: INVALID_REQUEST (message: Insufficient resource quota: CPU quota
exceeded by 1.00 core(s); RAM quota exceeded by 1024.00 MB; DISK quota exceeded by 1024.00
MB))


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message