aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <>
Subject Re: Review Request 28451: Modify TRequestsTransport to raise an exception 4xx or 5xx responses.
Date Tue, 25 Nov 2014 22:35:07 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 25, 2014, 2:35 p.m.)

Review request for Aurora, Kevin Sweeney and Bill Farner.

Bugs: AURORA-949

Repository: aurora


This changes TRequestsTransport to raise an exception on 4xx or 5xx responses. Previously
the TRequestsTransport would ignore those responses and treat the response as valid. The response
would not be valid JSON and cause thrift decoding errors later on.

Diffs (updated)

  src/main/python/apache/aurora/common/ 6f7c355d725b5e537cc4ae471170eaa8431da326

  src/test/python/apache/aurora/common/ c722eae2d04dec90e9c772f49c578184a2bdf76c



./pants src/test/python/apache/aurora/common:test_transport -v


Zameer Manji

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message