aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 28445: Improving messages in CronJobManager.
Date Tue, 25 Nov 2014 19:13:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28445/#review63021
-----------------------------------------------------------

Ship it!


Master (22dd641) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Nov. 25, 2014, 6:58 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28445/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2014, 6:58 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-924
>     https://issues.apache.org/jira/browse/AURORA-924
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixed checkCronExists() error message.
> 
> Also, refactored message handling and added tests to bring the branch coverage to 100%.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 28f1ae72aec392d6b2666e8993920106b8e3138f

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java 934e9bb669e6647dfbc2b43f00d036bad19932e5

> 
> Diff: https://reviews.apache.org/r/28445/diff/
> 
> 
> Testing
> -------
> 
> ./graldew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message