aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 28398: Adding cron check into aurora beta-update start.
Date Tue, 25 Nov 2014 18:00:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28398/
-----------------------------------------------------------

(Updated Nov. 25, 2014, 6 p.m.)


Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.


Changes
-------

CR comments.


Bugs: AURORA-921
    https://issues.apache.org/jira/browse/AURORA-921


Repository: aurora


Description
-------

Failing fast "aurora beta-update start" when a cron schedule is specified.

Also, updated cron command help messages and docs.


Diffs (updated)
-----

  docs/clientv2.md 6e69af3837f63321e273f1df7b0f5a1c07505cc7 
  docs/cron-jobs.md 7d04bcd3776bfd85f14e4398c4bc57dfbbdbcc72 
  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a5e869fc52ab6c4c28e6965585b015440f448f59

  src/main/python/apache/aurora/client/cli/cron.py cfd957cb99fb1c0bff04f0c91969a66faaf3b6f2

  src/main/python/apache/aurora/client/cli/update.py 12774af8bcd1c953fdbc799b0a142c27407d69f5

  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java de5f21a084109e5f31a7e5fca1b8ee265e30b893

  src/test/python/apache/aurora/client/cli/test_supdate.py 7637352feea6b07408256158814c05bc17ec14f3


Diff: https://reviews.apache.org/r/28398/diff/


Testing
-------

./pants src/test/python:all

Tested in vagrant.


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message