aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 28360: Make PreemptorImpl package private.
Date Sat, 22 Nov 2014 01:53:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28360/#review62717
-----------------------------------------------------------

Ship it!


Master (a431b1d) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Nov. 22, 2014, 1:34 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28360/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2014, 1:34 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Make PreemptorImpl package private.  This is a pure refactor, moving PreemptorImpl out
of Preemptor.  The detla looks much larger than it is.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 767e6010c28158860e3ac5710158466fe1925cad

>   src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java bc96b6713b7d4624ae4d0730c5b822ca9d6001d0

>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 42233e53621a08ca10226aeea2b27c66bdae8123

>   src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java 65581ba03583dcfa931f2aa412c8616d97c44c41

> 
> Diff: https://reviews.apache.org/r/28360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message