aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.
Date Fri, 21 Nov 2014 20:29:07 GMT


> On Nov. 21, 2014, 6:48 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/async/Preemptor.java, line 301
> > <https://reviews.apache.org/r/28310/diff/3/?file=772285#file772285line301>
> >
> >     newline?
> 
> Bill Farner wrote:
>     Not sure what you're requesting here.  Where would you like to see a newline?

This line is a continuation, so I expected a newline after it as per our guidelines.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28310/#review62590
-----------------------------------------------------------


On Nov. 21, 2014, 7:42 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28310/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2014, 7:42 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-121
>     https://issues.apache.org/jira/browse/AURORA-121
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is to pull out the bits that will be cached for performance improvements.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 19bf162586b90329e764cacf992df37ca68b0dc0

>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 4e37f4c9c8d4cde477a96a9b8cca7a075f170919

>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 97d5d13fcb686c7199ccf92ddab04931d6d5ab57

>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java f247ccfb115d4daa10fd4ca46750f708a093791b

>   src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterState.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterState.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 962aff8f4fa590935773c9fe90b1a6f59bc1c51f

>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 69108cf93e8478b54b0292c27ff56074448ec793

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 17f2d77bd1a143a9388ff1f52fa8edfcdfe08d91

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 012804a72fddb3e05f01d7e556cd577c07614ede

>   src/test/java/org/apache/aurora/scheduler/async/preemptor/LiveClusterStateTest.java
PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModuleTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28310/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message