aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 28272: Avoid creating garbage copies of Snapshot#tasks and AssignedTask#task.
Date Thu, 20 Nov 2014 01:43:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28272/#review62316
-----------------------------------------------------------


Master (065a3c5) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Nov. 20, 2014, 1:08 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28272/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 1:08 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-930
>     https://issues.apache.org/jira/browse/AURORA-930
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Avoid creating garbage copies of Snapshot#tasks and AssignedTask#task.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotDeduplicator.java 7b46740a5beb4b5bde4b5d41bea9573195e047b9

> 
> Diff: https://reviews.apache.org/r/28272/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> Suggestions on how to better test this are welcome.
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message