aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 27852: Ensure all verbs return an exit code.
Date Wed, 19 Nov 2014 23:10:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27852/#review62267
-----------------------------------------------------------

Ship it!



src/test/python/apache/aurora/client/cli/test_task_run.py
<https://reviews.apache.org/r/27852/#comment104279>

    Drop the temp var, do `cmd.execute()` and `assert` in one statement.


- Bill Farner


On Nov. 14, 2014, 10:16 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27852/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 10:16 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-923
>     https://issues.apache.org/jira/browse/AURORA-923
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ensure all verbs return an exit code.
> 
> This patch ensures all verbs returns an exit code and all verbs implement the execute
method.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8

>   src/main/python/apache/aurora/client/cli/task.py 91175facdc8ccccc9fd59ab66781f86ee8b5940a

>   src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649

>   src/test/python/apache/aurora/client/cli/test_kill.py e3a366bf67074e50787394cad58d5e01359b641e

>   src/test/python/apache/aurora/client/cli/test_task_run.py 8d9ef0543c1ab514d6f039ba63a1d417a4a90a1b

> 
> Diff: https://reviews.apache.org/r/27852/diff/
> 
> 
> Testing
> -------
> 
> ./pants build src/test/python/apache/aurora/client/cli::
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message