aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.
Date Sun, 16 Nov 2014 22:36:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28103/#review61690
-----------------------------------------------------------


Master (8741cdb) is red with this patch.
  ./build-support/jenkins/build.sh

virtualenv-1.11.6/virtualenv.py
virtualenv-1.11.6/virtualenv_embedded/
virtualenv-1.11.6/virtualenv_embedded/activate.bat
virtualenv-1.11.6/virtualenv_embedded/activate.csh
virtualenv-1.11.6/virtualenv_embedded/activate.fish
virtualenv-1.11.6/virtualenv_embedded/activate.ps1
virtualenv-1.11.6/virtualenv_embedded/activate.sh
virtualenv-1.11.6/virtualenv_embedded/activate_this.py
virtualenv-1.11.6/virtualenv_embedded/deactivate.bat
virtualenv-1.11.6/virtualenv_embedded/distutils-init.py
virtualenv-1.11.6/virtualenv_embedded/distutils.cfg
virtualenv-1.11.6/virtualenv_embedded/site.py
virtualenv-1.11.6/virtualenv_support/
virtualenv-1.11.6/virtualenv_support/__init__.py
virtualenv-1.11.6/virtualenv_support/pip-1.5.6-py2.py3-none-any.whl
virtualenv-1.11.6/virtualenv_support/setuptools-3.6-py2.py3-none-any.whl
+ touch virtualenv-1.11.6/BOOTSTRAPPED
+ popd
~/jenkins-slave/workspace/AuroraBot
+ exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-1.11.6/virtualenv.py
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv
New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/bin/python2.7
Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/bin/python
Installing setuptools, pip...done.
Downloading/unpacking Markdown==2.1.1 (from -r /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants_requirements.txt
(line 5))
Cleaning up...
Exception:
Traceback (most recent call last):
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pip/basecommand.py",
line 122, in main
    status = self.run(options, args)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pip/commands/install.py",
line 278, in run
    requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pip/req.py",
line 1197, in prepare_files
    do_download,
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pip/req.py",
line 1375, in unpack_url
    self.session,
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pip/download.py",
line 546, in unpack_http_url
    resp = session.get(target_url, stream=True)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py",
line 468, in get
    return self.request('GET', url, **kwargs)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pip/download.py",
line 237, in request
    return super(PipSession, self).request(method, url, *args, **kwargs)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py",
line 456, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py",
line 559, in send
    r = adapter.send(request, **kwargs)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pip/_vendor/requests/adapters.py",
line 384, in send
    raise Timeout(e, request=request)
Timeout: HTTPSConnectionPool(host='pypi.python.org', port=443): Read timed out.

Storing debug log for failure in /home/jenkins/.pip/pip.log


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Nov. 16, 2014, 10:29 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28103/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2014, 10:29 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Simplify Preemptor code, encapsulate fields used there and in SchedulingFilter.
> 
> A lot of this addressing Law of Demeter violations, such as accepting `IAssignedTask`
when only `ITaskConfig` and task ID were needed.  There are also (what i consider) readability
improvements in `SchedulingFilterImpl` and `PreemptorImpl`.
> 
> The broader goal here is to simplify the code usedin scheduling, hopefully to make forthcoming
scheduling performance improvements less complicated.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java ff26c49729646ffe052cb0a993b9984ae96a89ac

>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 6bfa3ac425ed3045fa60d1b0ca547e9bf3cde37a

>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java a2997f518f90eac34cb6fbb1104240b823d45f22

>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 8cf845f3622392a65216e0c29084965c7c64075d

>   src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java ca53303a675be60300cc1b6534164fa6da7ddbd7

>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 3839083f27ca5d4b93406152559b58b04e912a10

>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java c1c5f26723f1eac3000e09e061b4582f922fded6

>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java cc6b53b3265253f76c1e954c0108aa5936f5cc36

>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 4abc7ba36c547624af51fabc0983099efe5798ea

>   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 79d12b0dd7959b5443ffce43d9ebdb79135718bb

>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 8b0367ec99701084ce0cf55229a363c4b0b66b8f

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 9bc6a7535bf69dbc19771aa1834aeb04f42eea48

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java d1bc9bfe987b83356483cf1fb04aef2eb51eb141

>   src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
94f0a179b786649775899f855f7c1a0caab7290f 
>   src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java e113eba1f304279b5ee3d70db1d1ea558efd63ac

>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java a8a70b65c6f91371b9afad4dd3806a7c86fba04f

> 
> Diff: https://reviews.apache.org/r/28103/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message