aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Review Request 28066: Fixing flaky test.
Date Sat, 15 Nov 2014 01:06:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28066/
-----------------------------------------------------------

Review request for Aurora and Kevin Sweeney.


Bugs: AURORA-798
    https://issues.apache.org/jira/browse/AURORA-798


Repository: aurora


Description
-------

Looking at the EeasyMock.Results it does not appear to be thread safe wrt call count recording.
That resulted in about 20% flakiness that I could repro locally. Replacing the exact count
expectations by .atLeastOnce() as the test conditions are still asserted by the CountdownLatch.


Diffs
-----

  src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 6e499d1d82d5748ffc0d578283139f39e93316a7


Diff: https://reviews.apache.org/r/28066/diff/


Testing
-------

./gradlew -Pq build


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message