aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin" <da...@dmclaughlin.com>
Subject Re: Review Request 28019: Show update page URL in the output for beta-update start.
Date Fri, 14 Nov 2014 01:44:00 GMT


> On Nov. 14, 2014, 1:22 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, lines 83-85
> > <https://reviews.apache.org/r/28019/diff/1/?file=763026#file763026line83>
> >
> >     How about combining the two into something like: "Job update has started. View
update progress at %s"?

Done.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28019/#review61364
-----------------------------------------------------------


On Nov. 14, 2014, 12:19 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28019/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 12:19 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-766
>     https://issues.apache.org/jira/browse/AURORA-766
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Show update page URL in the output for beta-update start.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py df9dc24a060ef551009f48687fe9ecd928ee04a4

>   src/main/python/apache/aurora/client/cli/update.py 30763920bbc0b7e7a19e9a1a873d72680b7f821b

>   src/test/python/apache/aurora/client/cli/test_supdate.py 97a9664a5230a7331bd7b784cbbc958d4c07cbb1

> 
> Diff: https://reviews.apache.org/r/28019/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/client/cli/:all
> ./build-support/python/checkstyle-check src/
> ./build-support/python/isort-check src/
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message