aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@twopensource.com>
Subject Re: Review Request 27954: Fix bad review text in review bot.
Date Thu, 13 Nov 2014 17:40:30 GMT


> On Nov. 13, 2014, 4:29 a.m., Kevin Sweeney wrote:
> > build-support/jenkins/review_feedback.py, line 178
> > <https://reviews.apache.org/r/27954/diff/1/?file=760871#file760871line178>
> >
> >     prefer interpolation with % review_text
> >     
> >     over string concatenation

+1


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27954/#review61204
-----------------------------------------------------------


On Nov. 13, 2014, 2:03 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27954/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2014, 2:03 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Addressing bad output displayed in https://reviews.apache.org/r/27947/
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/review_feedback.py eaccfa81c323c9f5d284f16d5836e848a05bcb6d 
> 
> Diff: https://reviews.apache.org/r/27954/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message