aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 27947: Setting the max thread limit on AsyncEventBus.
Date Thu, 13 Nov 2014 04:27:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/#review61203
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java
<https://reviews.apache.org/r/27947/#comment102725>

    I don't think we want enqueuing a pubsubevent for processing to block, ever (otherwise
we open ourselves to the possibility of deadlocks here). Consider using a LinkedBlockingQueue
instead here. As this queue is still bounded at MAX_INT we might further consider adding a
https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/RejectedExecutionHandler.html
that logs an appropriate message and shuts down the scheduler to make debugging easier.


- Kevin Sweeney


On Nov. 12, 2014, 5:12 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27947/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2014, 5:12 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-926
>     https://issues.apache.org/jira/browse/AURORA-926
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Setting the max thread limit on AsyncEventBus.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 24cd750c676a280d1cc953c96df126f19fc478f2

> 
> Diff: https://reviews.apache.org/r/27947/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message