aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@twopensource.com>
Subject Re: Review Request 27892: Fixes for the make pycharm script:
Date Wed, 12 Nov 2014 19:29:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/
-----------------------------------------------------------

(Updated Nov. 12, 2014, 7:29 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
-------

Quote heredoc limit string.


Repository: aurora


Description
-------

Fixes for the make pycharm script:

1. Escape $'s
2. Use root directory name as project name
3. Exclude some noisy directories


Diffs (updated)
-----

  build-support/python/make-pycharm-virtualenv 316ead7c92e0510cd53958f419686e902dc34204 

Diff: https://reviews.apache.org/r/27892/diff/


Testing
-------

$ cat .idea/incubator-aurora.iml 
<?xml version="1.0" encoding="UTF-8"?>
<module type="PYTHON_MODULE" version="4">
  <component name="NewModuleRootManager">
    <content url="file://$MODULE_DIR$">
      <sourceFolder url="file://$MODULE_DIR$/src/main/python" isTestSource="false" />
      <excludeFolder url="file://$MODULE_DIR$/.pants.d" />
      <excludeFolder url="file://$MODULE_DIR$/dist" />
      <excludeFolder url="file://$MODULE_DIR$/out" />
    </content>
    <orderEntry type="inheritedJdk" />
    <orderEntry type="sourceFolder" forTests="false" />
  </component>
  <component name="TestRunnerService">
    <option name="projectConfiguration" value="py.test" />
    <option name="PROJECT_TEST_RUNNER" value="py.test" />
  </component>
</module>


Thanks,

Joshua Cohen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message