aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 27889: Send an event for host attributes changing rather than maintenance mode changing.
Date Tue, 11 Nov 2014 22:51:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27889/#review60886
-----------------------------------------------------------

Ship it!



src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
<https://reviews.apache.org/r/27889/#comment102292>

    Is this needed anymore? Maintenance doesn't have a dependency on pubsub anymore right?


- Kevin Sweeney


On Nov. 11, 2014, 2:42 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27889/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2014, 2:42 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
> 
> 
> Bugs: AURORA-913
>     https://issues.apache.org/jira/browse/AURORA-913
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> One step closer to caching host attributes.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java fef76f5069a80959eaba04f1b4b93ff3f6ba43dd

>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 14c3e3a593f72af696106d948767d85075b8726b

>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 9c095d932ada9f42cd473bc5d782883b0522c3cf

>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 0ba31ac5b17dd6dfa4e5f58d4e018cdb9b78172f

>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 88418e61a371626d2c6390a36d3a3284db8d76be

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 32890f5b390214bfa630dae0445fdde735f98ccf

>   src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java c6250b4a1b4cf168c451f1cfb87a02ef2ce4841d

>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 662ebdceff580af0a05f9a89d50ca1c90ddc9070

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 2f525104022448c200bfddc5a88252987fc86d0f

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 7736d4cec260eba0938acaf9f884597a3e35f08e

>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
99fa11ba15f1af9a4fd6fc31bb45020083d11806 
>   src/test/java/org/apache/aurora/scheduler/state/PubsubTestUtil.java e884209fd5965e50847f14b09a43f6aba4946b7e

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java c6ff43fdc07183d8e30d3db0a1af7c762255076f

>   src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java a553c566a14eda29862fe414f348dc071d0e638c

> 
> Diff: https://reviews.apache.org/r/27889/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message