aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 27772: Fix false passing test case in SchedulerDriverServiceTest.
Date Mon, 10 Nov 2014 18:56:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27772/#review60639
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On Nov. 7, 2014, 9:53 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27772/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 9:53 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I noticed this test was encountering an AssertionError, but passing anyway because the
desired result was still matched:
> 
> `Exception: java.lang.AssertionError thrown from the UncaughtExceptionHandler in thread
"SchedulerDriverService STARTING"`
> 
> 
> Diffs
> -----
> 
>   src/test/java/org/apache/aurora/scheduler/mesos/SchedulerDriverServiceTest.java 11f59c96a3676bd1ed7843ba0b99e7b196a4c98c

> 
> Diff: https://reviews.apache.org/r/27772/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message