aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 27601: Adding resource consumption calculation for cron jobs.
Date Thu, 06 Nov 2014 21:02:49 GMT


> On Nov. 6, 2014, 5:56 p.m., Maxim Khutornenko wrote:
> > Ping. The actual diff is tiny: https://reviews.apache.org/r/27601/diff/1-2/

Sorry, we've been in various firefights the last few days, reviewing shortly.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27601/#review60195
-----------------------------------------------------------


On Nov. 5, 2014, 1:23 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27601/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 1:23 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-825
>     https://issues.apache.org/jira/browse/AURORA-825
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixing cron template filtering issue. 
> 
> This is the revision of the original implementation submitted in https://reviews.apache.org/r/27317
and reverted shorly after.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java d4e0f5335c9ebd8da97cb9634152b46c2bd9affe

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 3fbab8b27403a416e86c97970eb6124c8a34c38c

>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2fe257416e8fc11be3ebf0dabbf4f63628b3c670

> 
> Diff: https://reviews.apache.org/r/27601/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> Also, created multiple role cron jobs in vagrant to validate filtering.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message