aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 27628: Convert most uses of Mock to create_autospec, remove some uses of mocking altogether.
Date Thu, 06 Nov 2014 02:26:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27628/#review60094
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On Nov. 5, 2014, 4:47 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27628/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 4:47 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Bugs: AURORA-889
>     https://issues.apache.org/jira/browse/AURORA-889
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Most of these are find/replace on Mock to use create_autospec instead.  There are a few
additional changes of note:
> - introduction of `api_util.py` to provide a speccable interface for what `SchedulerProxy`
supports
> - converted many (but not all) unnecessary uses of mocks to concrete objects
> - attempted to explore an improved test pattern in `test_restart_failed_status` (`test_restart.py`)
to avoid a Mock for the options object
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/update.py 1d3fd667c36fab7fec060ad1d0f5d3825667fc27

>   src/test/python/apache/aurora/client/api/api_util.py PRE-CREATION 
>   src/test/python/apache/aurora/client/api/test_api.py 47b5236edde4a396f99b47b0a25f9a02dd8bf689

>   src/test/python/apache/aurora/client/api/test_job_monitor.py cb2503e41c7643f9398f31dd3fca64a0b94c4383

>   src/test/python/apache/aurora/client/api/test_quota_check.py d75bd1bd5a3e11c8d82d1a1b15e1b8619de3ac0d

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py af8353edef92d79f20779beca2785318b4e05ceb

>   src/test/python/apache/aurora/client/api/test_task_util.py 582c708f09e3efb0fca32713a0b6e2f44d24ab22

>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 3e7006ed4375ddbb5533fd2235e5aa3e4e8666a4

>   src/test/python/apache/aurora/client/cli/test_cancel_update.py fb5a527a3ec32028371732fca5ac186ecc0d325a

>   src/test/python/apache/aurora/client/cli/test_command_hooks.py eb4d413e42c7653ca52950536f693306c591a048

>   src/test/python/apache/aurora/client/cli/test_create.py 6013fa1354ca2ac8ebe30ce5ae49e885f33ac2f2

>   src/test/python/apache/aurora/client/cli/test_cron.py b84bbfc1eace430ff64af3c77b2cf093c6525c80

>   src/test/python/apache/aurora/client/cli/test_diff.py f7c07f2e4d44db20250337a053ce6b841cc22a63

>   src/test/python/apache/aurora/client/cli/test_inspect.py b5b949b5e10c406786290bc6bfb706e430c21222

>   src/test/python/apache/aurora/client/cli/test_kill.py 6f5b1bb1cf982362c4bb2cd911558a2bd0eca61c

>   src/test/python/apache/aurora/client/cli/test_logging.py 10fa015b697554d4786aa4ade0e90b91bc8f18cc

>   src/test/python/apache/aurora/client/cli/test_plugins.py 0b29346c107ca7341b2c7c5639ded607310b81b1

>   src/test/python/apache/aurora/client/cli/test_quota.py 6e38227b19872be86b989663b5b206b533d8c9b6

>   src/test/python/apache/aurora/client/cli/test_restart.py ff702648777b0e719b910faf08a5bcda798e94eb

>   src/test/python/apache/aurora/client/cli/test_sla.py a7bfd35701fc57875bcbc939eab9688d0afa0d90

>   src/test/python/apache/aurora/client/cli/test_status.py 6b2f18b28ec46a7bb8e250bb17455bf2bc679585

>   src/test/python/apache/aurora/client/cli/test_supdate.py bf979e27799da56a2781a3af8370bd44cb216f78

>   src/test/python/apache/aurora/client/cli/test_task_run.py 8458606d282a3bcef8129d25fa123d28f8f8f7df

>   src/test/python/apache/aurora/client/cli/test_update.py 840cde982c310e257263add1848e4225b22eaa04

>   src/test/python/apache/aurora/client/cli/util.py 796c4f9880a0f834a6950472892981e8a6789a97

>   src/test/python/apache/aurora/client/commands/test_admin.py cae539594dc73e05920d7ae08610634e7458178c

>   src/test/python/apache/aurora/client/commands/test_admin_sla.py a565318d1044f52571de41a921842c606edbc437

>   src/test/python/apache/aurora/client/commands/test_cancel_update.py 5d2a7898e95266e94e041e68b1471fc47606286d

>   src/test/python/apache/aurora/client/commands/test_create.py be69ed57cc328d39c5866f0737a727241445e160

>   src/test/python/apache/aurora/client/commands/test_diff.py 9a486c3551a8bf0e269e51f64406bc96e3cf7161

>   src/test/python/apache/aurora/client/commands/test_hooks.py 638fba625c3cbaa3bf4a96e5f04d3bf5055b778b

>   src/test/python/apache/aurora/client/commands/test_kill.py 8194c9622e4789f1fae28dc9eb21e2f17ac51b79

>   src/test/python/apache/aurora/client/commands/test_listjobs.py d9fa617129d46c3fa3e7cf092368788a04ad3a0a

>   src/test/python/apache/aurora/client/commands/test_restart.py 6da9e73c108d4d1908418cb9f6b6b1bc51d24879

>   src/test/python/apache/aurora/client/commands/test_run.py 738a42bd2a8aa56bb4900c1b48ecbd043eaa4b3e

>   src/test/python/apache/aurora/client/commands/test_ssh.py 6d51bb30581668e73250c4d6c8dc1b95d83a3762

>   src/test/python/apache/aurora/client/commands/test_status.py 062b1321e7342eac7c4408a966006d429268406f

>   src/test/python/apache/aurora/client/commands/test_update.py e359d32c9b4f4be975b4e7d0fd77e096300fb01d

>   src/test/python/apache/aurora/client/commands/util.py fb842582781c12389520f3bf896dc185f1b1904f

>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py 496bdb0eda338381f1315b953b1925df7a116dd7

>   src/test/python/apache/aurora/common/test_transport.py e0fef910a590ef6dc1f8e8467c04ba7b52d3825d

>   src/test/python/apache/aurora/executor/common/test_announcer.py a4ab532b30631f49b3e24ab751e5ec0dec4e0dce

>   src/test/python/apache/aurora/executor/common/test_executor_timeout.py ce4cfc86507c9da775eeb77dfc570f32d6979d2e

>   src/test/python/apache/aurora/executor/test_status_manager.py 8a0d48bd45e2a77d4024e66ae20d64213df72227

>   src/test/python/apache/thermos/core/test_helper.py fe368ff4ecb22f1d99024117c6b944c64f86b8ff

> 
> Diff: https://reviews.apache.org/r/27628/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message