aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@twopensource.com>
Subject Re: Review Request 27586: Increase robustness when reading PEX-INFO
Date Tue, 04 Nov 2014 21:22:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586/
-----------------------------------------------------------

(Updated Nov. 4, 2014, 1:22 p.m.)


Review request for Aurora and Bill Farner.


Changes
-------

Add tests to cover different PEX-INFO formats.


Bugs: AURORA-456
    https://issues.apache.org/jira/browse/AURORA-456


Repository: aurora


Description
-------

This patch prevents aurora version from crashing when it is built with a different version
of pants.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c

  src/test/python/apache/aurora/client/commands/BUILD 17933dedfa08c9d12c369087bf801e7c35cdde9b

  src/test/python/apache/aurora/client/commands/test_version.py PRE-CREATION 

Diff: https://reviews.apache.org/r/27586/diff/


Testing
-------

[tw-mbp-zmanji aurora (fix-version)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2
Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD,
aurora2)])
Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD,
aurora2)):
Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex
[tw-mbp-zmanji aurora (fix-version)]$ ./pants src/main/python/apache/aurora/client/bin:aurora_client
Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD,
aurora_client)])
Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/bin/BUILD,
aurora_client)):
Wrote /Users/zmanji/workspace/aurora/dist/aurora_client.pex
[tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora2.pex version
Aurora client build info:
	sha: d03187404dac583884a979dd302dd3cd36163c98
	date: Tuesday Nov 04, 2014 11:39:07
Aurora API version: APIVersion(major=3)
[tw-mbp-zmanji aurora (fix-version)]$ ./dist/aurora_client.pex version
Aurora client build info:
	sha: d03187404dac583884a979dd302dd3cd36163c98
	date: Tuesday Nov 04, 2014 11:39:18
Aurora API version: APIVersion(major=3)


Thanks,

Zameer Manji


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message