aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.
Date Mon, 03 Nov 2014 21:24:18 GMT


> On Nov. 3, 2014, 5:59 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 178
> > <https://reviews.apache.org/r/27467/diff/1/?file=746652#file746652line178>
> >
> >     Does not read right, s/of/if/?

Thanks, fixed.


> On Nov. 3, 2014, 5:59 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/async/KillRetry.java, line 81
> > <https://reviews.apache.org/r/27467/diff/1/?file=746653#file746653line81>
> >
> >     How about a stat counter here as well?

Good call, done.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27467/#review59591
-----------------------------------------------------------


On Nov. 1, 2014, 5:48 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27467/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2014, 5:48 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-910
>     https://issues.apache.org/jira/browse/AURORA-910
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Retry Driver.killTask periodically until the task changes states.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java df7e56a955fef21d48e75797bb5761453ae1e57a

>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 748aac83db7c470dc7aed7936e629400c3e6c2d8

>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 1688a339a1a9c4072d7f834963cb5ccad6fe0736

> 
> Diff: https://reviews.apache.org/r/27467/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message