aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 27317: Adding resource consumption calculation for cron jobs.
Date Mon, 03 Nov 2014 18:51:53 GMT


> On Nov. 3, 2014, 6:38 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java, line 16
> > <https://reviews.apache.org/r/27317/diff/1/?file=736702#file736702line16>
> >
> >     java.util.Objects

Done.


> On Nov. 3, 2014, 6:38 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java, line 87
> > <https://reviews.apache.org/r/27317/diff/1/?file=736702#file736702line87>
> >
> >     You'll need to fully-qualify this until we're on Guava 18, which renames this
class to MoreObjects.
> >     
> >     ```java
> >     return com.google.common.base.Objects.toStringHelper(this)
> >        ...
> >        .toString();
> >     ```

Done.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27317/#review58937
-----------------------------------------------------------


On Oct. 30, 2014, 5:11 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27317/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 5:11 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-825
>     https://issues.apache.org/jira/browse/AURORA-825
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Cron job consumption is now calculated as MAX(SUM(template), SUM(tasks)). This is rolled
up into overall role consumption for reporting and quota checks.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java d4e0f5335c9ebd8da97cb9634152b46c2bd9affe

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 3fbab8b27403a416e86c97970eb6124c8a34c38c

>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2fe257416e8fc11be3ebf0dabbf4f63628b3c670

> 
> Diff: https://reviews.apache.org/r/27317/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message