Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 37F7A1781E for ; Thu, 30 Oct 2014 00:19:08 +0000 (UTC) Received: (qmail 27012 invoked by uid 500); 30 Oct 2014 00:19:08 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 26968 invoked by uid 500); 30 Oct 2014 00:19:08 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 26949 invoked by uid 99); 30 Oct 2014 00:19:07 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Oct 2014 00:19:07 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 30 Oct 2014 00:18:45 +0000 Received: (qmail 26588 invoked by uid 99); 30 Oct 2014 00:18:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Oct 2014 00:18:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E9FED1DF943; Thu, 30 Oct 2014 00:18:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7672635809526469621==" MIME-Version: 1.0 Subject: Re: Review Request 27363: Add explicit test coverage for stat gauge in TaskSchedulerImpl. From: "Joshua Cohen" To: "Maxim Khutornenko" , "Joshua Cohen" Cc: "Bill Farner" , "Aurora" Date: Thu, 30 Oct 2014 00:18:47 -0000 Message-ID: <20141030001847.7143.38244@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Joshua Cohen" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/27363/ X-Sender: "Joshua Cohen" References: <20141030001429.7137.79986@reviews.apache.org> In-Reply-To: <20141030001429.7137.79986@reviews.apache.org> Reply-To: "Joshua Cohen" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============7672635809526469621== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27363/#review59085 ----------------------------------------------------------- Ship it! Ship It! - Joshua Cohen On Oct. 30, 2014, 12:14 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27363/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 12:14 a.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-884 > https://issues.apache.org/jira/browse/AURORA-884 > > > Repository: aurora > > > Description > ------- > > Add explicit test coverage for stat gauge in TaskSchedulerImpl. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 5739c39e548092f15e50e639344e24161f6305dc > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 5d12df99a29cddf97b3ef49a9de1a747c16461fe > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java fe57375c11447dd79f44e1ba0ddc3e5ca37741ea > > Diff: https://reviews.apache.org/r/27363/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============7672635809526469621==--