Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 21B9517914 for ; Tue, 28 Oct 2014 21:10:05 +0000 (UTC) Received: (qmail 76012 invoked by uid 500); 28 Oct 2014 21:10:04 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 75970 invoked by uid 500); 28 Oct 2014 21:10:04 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 75958 invoked by uid 99); 28 Oct 2014 21:10:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Oct 2014 21:10:04 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 28 Oct 2014 21:10:02 +0000 Received: (qmail 74184 invoked by uid 99); 28 Oct 2014 21:09:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Oct 2014 21:09:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4FE421DF83D; Tue, 28 Oct 2014 21:09:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4217642384365413570==" MIME-Version: 1.0 Subject: Re: Review Request 27309: Make executor overhead configurable via CLI. From: "Aurora ReviewBot" To: "Bill Farner" Cc: "Aurora ReviewBot" , "Aurora" , "Zameer Manji" Date: Tue, 28 Oct 2014 21:09:47 -0000 Message-ID: <20141028210947.7137.42154@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/27309/ X-Sender: "Aurora ReviewBot" References: <20141028205703.7137.96533@reviews.apache.org> In-Reply-To: <20141028205703.7137.96533@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4217642384365413570== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27309/#review58867 ----------------------------------------------------------- Master (a518053) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.commands.ssh ..... SUCCESS src.test.python.apache.aurora.client.config ..... SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS src.test.python.apache.aurora.common.test_cluster ..... SUCCESS src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS src.test.python.apache.aurora.common.test_clusters ..... SUCCESS src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS src.test.python.apache.aurora.common.test_shellify ..... SUCCESS src.test.python.apache.aurora.common.test_transport ..... SUCCESS src.test.python.apache.aurora.config.test_base ..... SUCCESS src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS src.test.python.apache.aurora.config.test_loader ..... SUCCESS src.test.python.apache.aurora.config.test_thrift ..... SUCCESS src.test.python.apache.aurora.executor.executor_base ..... SUCCESS src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS src.test.python.apache.aurora.executor.status_manager ..... SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner ..... FAILURE - Aurora ReviewBot On Oct. 28, 2014, 8:57 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27309/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 8:57 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-830 > https://issues.apache.org/jira/browse/AURORA-830 > > > Repository: aurora > > > Description > ------- > > Make executor overhead configurable via CLI. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f > src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594 > > Diff: https://reviews.apache.org/r/27309/diff/ > > > Testing > ------- > > ./gradlew clean build -Pq > > > Thanks, > > Zameer Manji > > --===============4217642384365413570==--