Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============3829895166694964634=="
MIME-Version: 1.0
Subject: Re: Review Request 25794: Add a mock scheduler client to the
 AuroraClient service
From: "Aurora ReviewBot" <wfarner@apache.org>
To: "Bill Farner" <wfarner@apache.org>, "Kevin Sweeney" <kevints@apache.org>,
 "Maxim Khutornenko" <maxim@apache.org>,
 "Joshua Cohen" <jcohen@twopensource.com>
Cc: "Aurora ReviewBot" <wfarner@apache.org>,
 "Aurora" <reviews@aurora.incubator.apache.org>,
 "David McLaughlin" <david@dmclaughlin.com>
Date: Fri, 24 Oct 2014 02:07:33 -0000
Message-ID: <20141024020733.1282.6966@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Aurora ReviewBot" <noreply@reviews.apache.org>
References: <20140918213829.7803.26429@reviews.apache.org>
In-Reply-To: <20140918213829.7803.26429@reviews.apache.org>
Reply-To: "Aurora ReviewBot" <wfarner@apache.org>

--===============3829895166694964634==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25794/#review58219
-----------------------------------------------------------


This patch does not apply cleanly on master (53f4e73), do you need to rebase?

- Aurora ReviewBot


On Sept. 18, 2014, 9:38 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25794/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 9:38 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a mock scheduler client to the AuroraClient service.
> 
> There is probably a more Angular way to get this done which involves creating a mock service, but this seemed like the simplest approach.
> 
> Interested in whether this is the right place to do mocking (or should it come from the server so that we have more coverage of the client code?) or if we should mock at all. 
> 
> Code itself needs cleaned up - I just want to solicit feedback before I go too far down a bad path. 
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8a719f85b0a095a93b723c04b0a5e8306093c572 
> 
> Diff: https://reviews.apache.org/r/25794/diff/
> 
> 
> Testing
> -------
> 
> In Chrome -> Developer Console:
> 
> window.__mockAPI__ = true;
> 
> Now I have updates in the UI. 
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


--===============3829895166694964634==--