Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 20A4A1763B for ; Fri, 17 Oct 2014 17:59:18 +0000 (UTC) Received: (qmail 84013 invoked by uid 500); 17 Oct 2014 17:59:18 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 83972 invoked by uid 500); 17 Oct 2014 17:59:18 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 83961 invoked by uid 99); 17 Oct 2014 17:59:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Oct 2014 17:59:17 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 17 Oct 2014 17:58:54 +0000 Received: (qmail 83874 invoked by uid 99); 17 Oct 2014 17:58:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Oct 2014 17:58:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DA2731DF426; Fri, 17 Oct 2014 17:58:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3487110713163442641==" MIME-Version: 1.0 Subject: Review Request 26881: Improve error messages in client commands. From: "Mark Chu-Carroll" To: "Bill Farner" , "Zameer Manji" Cc: "Aurora" , "Mark Chu-Carroll" Date: Fri, 17 Oct 2014 17:58:47 -0000 Message-ID: <20141017175847.30984.20458@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mark Chu-Carroll" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26881/ X-Sender: "Mark Chu-Carroll" Reply-To: "Mark Chu-Carroll" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3487110713163442641== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26881/ ----------------------------------------------------------- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: aurora-771 https://issues.apache.org/jira/browse/aurora-771 Repository: aurora Description ------- When a client command fails due to an error in an API call, it used to log whatever messages came back in the reply from the server, and then generate a message saying "... see log for details". This change improves that behavior. Now, an error message is generated saying something like "Command failed due to error reported by server", followed by a group of indented lines containing the messages from the server. For example, a new error message would look like: Server reported error restarting job west/bozo/test/hello Job 'west/bozo/test/hello' not found. Diffs ----- src/main/python/apache/aurora/client/cli/context.py 4e94a4e3017f3b2ace38d6d8ce68c3c778c8cd0e src/main/python/apache/aurora/client/cli/cron.py 061b1d4f768f299d6db72c66f6bb75fdb68bc0d7 src/main/python/apache/aurora/client/cli/jobs.py 0277cbed4b7eb927d6e5823b4b41d90b366f81d0 src/main/python/apache/aurora/client/cli/quota.py 137aab1285a9732a3b65aee65948e836df3c7cac src/main/python/apache/aurora/client/cli/update.py 8a02b8a8b0bb531248949213da97cbc1a380bf64 src/test/python/apache/aurora/client/cli/test_create.py 427f7ce4476b48d407b8bd2bf2c54c52e6e63079 src/test/python/apache/aurora/client/cli/test_kill.py bac4485fa105848d96e2505c4a2ea2eee45dc968 src/test/python/apache/aurora/client/cli/test_restart.py a5f94484b30ecb8417116db9ce12c015957357c5 src/test/python/apache/aurora/client/cli/test_supdate.py 6775c389cb1a0b80dd17fe179e8b98d4e9db0332 Diff: https://reviews.apache.org/r/26881/diff/ Testing ------- Thanks, Mark Chu-Carroll --===============3487110713163442641==--