Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============5015986739966943838=="
MIME-Version: 1.0
Subject: Re: Review Request 26845: Adding Aurora scheduler storage doc.
From: "Jay Buffington" <me@jaybuff.com>
To: "Bill Farner" <wfarner@apache.org>, "Kevin Sweeney" <kevints@apache.org>
Cc: "Aurora" <reviews@aurora.incubator.apache.org>,
 "Jay Buffington" <me@jaybuff.com>, "Maxim Khutornenko" <maxim@apache.org>
Date: Fri, 17 Oct 2014 15:19:53 -0000
Message-ID: <20141017151953.30953.71092@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Jay Buffington" <noreply@reviews.apache.org>
References: <20141017002114.24414.351@reviews.apache.org>
In-Reply-To: <20141017002114.24414.351@reviews.apache.org>
Reply-To: "Jay Buffington" <me@jaybuff.com>

--===============5015986739966943838==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26845/#review57143
-----------------------------------------------------------

Ship it!


Sorry for the late review after it already merged.  This doc is great and I learned a lot from it.  There's nothing wrong with this doc, but there are a few places I think you could expand on things.


docs/storage.md
<https://reviews.apache.org/r/26845/#comment97613>

    I'd like the see a paragraphic justifying avoiding the more traditional approaching of writing this data to a database like mysql or cassandra.  I think the justification is to remove deployment dependencies?


docs/storage.md
<https://reviews.apache.org/r/26845/#comment97610>

    I haven't really looked at the update features, yet.  Is this live and ready to go?  If not maybe defer referencing this until the updater work is shipped?


docs/storage.md
<https://reviews.apache.org/r/26845/#comment97607>

    This is pretty much the complete list of what is stored in the replicated log, right?  s/For Example/Aurora stores the follow data/


docs/storage.md
<https://reviews.apache.org/r/26845/#comment97612>

    Link to your doc that describes how to config and recover backups.  When I read this I immediatly want to know how often the snapshots are taken and what negative impact there is from taking snapshots too frequently.


docs/storage.md
<https://reviews.apache.org/r/26845/#comment97609>

    The ellipses serve no purpose. I'd remove them, but this is a minor knit.


- Jay Buffington


On Oct. 17, 2014, 12:21 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26845/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 12:21 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-839
>     https://issues.apache.org/jira/browse/AURORA-839
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Created a high level storage architecture write up.
> 
> 
> Diffs
> -----
> 
>   docs/images/storage_hierarchy.png PRE-CREATION 
>   docs/storage.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26845/diff/
> 
> 
> Testing
> -------
> 
> https://github.com/maxim111333/incubator-aurora/blob/storage_doc/docs/storage.md
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


--===============5015986739966943838==--