Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5AF2A17849 for ; Thu, 16 Oct 2014 19:44:48 +0000 (UTC) Received: (qmail 66371 invoked by uid 500); 16 Oct 2014 19:44:48 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 66327 invoked by uid 500); 16 Oct 2014 19:44:48 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 66316 invoked by uid 99); 16 Oct 2014 19:44:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Oct 2014 19:44:47 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 16 Oct 2014 19:44:25 +0000 Received: (qmail 64169 invoked by uid 99); 16 Oct 2014 19:44:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Oct 2014 19:44:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E4DBD1DF3A1; Thu, 16 Oct 2014 19:44:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6876524855104215985==" MIME-Version: 1.0 Subject: Re: Review Request 26790: Fix redirect loop when accessing rewritten paths. From: "Joshua Cohen" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Joshua Cohen" Date: Thu, 16 Oct 2014 19:44:18 -0000 Message-ID: <20141016194418.24426.67718@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Joshua Cohen" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26790/ X-Sender: "Joshua Cohen" References: <20141016040240.24426.66256@reviews.apache.org> In-Reply-To: <20141016040240.24426.66256@reviews.apache.org> Reply-To: "Joshua Cohen" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6876524855104215985== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26790/ ----------------------------------------------------------- (Updated Oct. 16, 2014, 7:44 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes ------- Add comment and rebase master. Bugs: AURORA-841 https://issues.apache.org/jira/browse/AURORA-841 Repository: aurora Description ------- Fix redirect loop when accessing rewritten paths. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java fe1e111ff556a463e7f1f90c4c785b0bc0b59ddc src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java e50de1eac86ed449b79ba66e0d6c5a488bc01a3f src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 53c708866e8abcb1e951265c707ff34e2331a3c4 Diff: https://reviews.apache.org/r/26790/diff/ Testing ------- ./gradlew build -Pq Also started up multiple schedulers in vagrant image and confirmed that I'm properly redirected when accessing the non-leading scheduler. Thanks, Joshua Cohen --===============6876524855104215985==--