Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B5158173D5 for ; Thu, 16 Oct 2014 17:47:26 +0000 (UTC) Received: (qmail 83267 invoked by uid 500); 16 Oct 2014 17:47:26 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 83223 invoked by uid 500); 16 Oct 2014 17:47:26 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 83212 invoked by uid 99); 16 Oct 2014 17:47:26 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Oct 2014 17:47:26 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 16 Oct 2014 17:47:25 +0000 Received: (qmail 83125 invoked by uid 99); 16 Oct 2014 17:47:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Oct 2014 17:47:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7C27F1DF389; Thu, 16 Oct 2014 17:47:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3066072612899861116==" MIME-Version: 1.0 Subject: Re: Review Request 26809: Add a metric to count offers that do not provide sufficent resources to launch a GC Executor From: "Kevin Sweeney" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Joe Smith" Date: Thu, 16 Oct 2014 17:47:00 -0000 Message-ID: <20141016174700.24426.90431@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26809/ X-Sender: "Kevin Sweeney" References: <20141016174535.24414.90443@reviews.apache.org> In-Reply-To: <20141016174535.24414.90443@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3066072612899861116== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 16, 2014, 10:45 a.m., Bill Farner wrote: > > LGTM, i'm ambivalent to the stat name. for consistency with the rest of the metrics exported by this file I prefer Zameer's suggestion - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26809/#review56951 ----------------------------------------------------------- On Oct. 16, 2014, 10:07 a.m., Joe Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26809/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 10:07 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-843 > https://issues.apache.org/jira/browse/AURORA-843 > > > Repository: aurora > > > Description > ------- > > Add a metric to count offers that do not provide sufficent resources to launch a GC Executor > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java cfab57896f9c76754ba3b42742504fb7e7a2cf79 > src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java f2d153f446247032ad9d8d173fb70870dbfdcca1 > > Diff: https://reviews.apache.org/r/26809/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Joe Smith > > --===============3066072612899861116==--