Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 64BBB17278 for ; Wed, 15 Oct 2014 17:55:57 +0000 (UTC) Received: (qmail 36306 invoked by uid 500); 15 Oct 2014 17:55:57 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 36261 invoked by uid 500); 15 Oct 2014 17:55:57 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 36245 invoked by uid 99); 15 Oct 2014 17:55:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Oct 2014 17:55:56 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 15 Oct 2014 17:55:34 +0000 Received: (qmail 34574 invoked by uid 99); 15 Oct 2014 17:55:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Oct 2014 17:55:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B5C021DDF44; Wed, 15 Oct 2014 17:55:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1692161904873003410==" MIME-Version: 1.0 Subject: Re: Review Request 26716: Use JobKey when getting roles to authenticate against. From: "Kevin Sweeney" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Zameer Manji" Date: Wed, 15 Oct 2014 17:55:27 -0000 Message-ID: <20141015175527.24426.56366@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26716/ X-Sender: "Kevin Sweeney" References: <20141015002354.24413.96995@reviews.apache.org> In-Reply-To: <20141015002354.24413.96995@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============1692161904873003410== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26716/#review56747 ----------------------------------------------------------- Ship it! Ship It! - Kevin Sweeney On Oct. 14, 2014, 5:23 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26716/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 5:23 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-837 > https://issues.apache.org/jira/browse/AURORA-837 > > > Repository: aurora > > > Description > ------- > > Use JobKey when getting roles to authenticate against. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/base/Query.java d8572bb21a92025e7a51cf18d5bdf00fc1281078 > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2 > src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 3b61ff3c237de3ec5224a239d1756ce8d7093a52 > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 0d51f7dc367081f72090736e36605bf363f3395e > > Diff: https://reviews.apache.org/r/26716/diff/ > > > Testing > ------- > > ./gradlew clean test > > > Thanks, > > Zameer Manji > > --===============1692161904873003410==--