Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5BC2F10BD8 for ; Wed, 15 Oct 2014 16:22:18 +0000 (UTC) Received: (qmail 91805 invoked by uid 500); 15 Oct 2014 16:22:18 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 91762 invoked by uid 500); 15 Oct 2014 16:22:18 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 91744 invoked by uid 99); 15 Oct 2014 16:22:17 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Oct 2014 16:22:17 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 15 Oct 2014 16:22:16 +0000 Received: (qmail 91493 invoked by uid 99); 15 Oct 2014 16:21:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Oct 2014 16:21:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 112551DDFB0; Wed, 15 Oct 2014 16:21:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2475786885769558110==" MIME-Version: 1.0 Subject: Re: Review Request 26720: Limit the amount of work done while bootstrapping thrift. From: "Bill Farner" To: "Zameer Manji" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" Date: Wed, 15 Oct 2014 16:21:52 -0000 Message-ID: <20141015162152.24413.8772@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26720/ X-Sender: "Bill Farner" References: <20141015010635.24426.82764@reviews.apache.org> In-Reply-To: <20141015010635.24426.82764@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============2475786885769558110== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 15, 2014, 1:06 a.m., Kevin Sweeney wrote: > > build-support/thrift/Makefile, line 49 > > > > > > Not your issue but this line appears impossible to execute. Removed. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26720/#review56632 ----------------------------------------------------------- On Oct. 15, 2014, 12:59 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26720/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 12:59 a.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Limit the amount of work done while bootstrapping thrift. > > > Diffs > ----- > > build-support/thrift/Makefile 2b62b15ee946862b2bea6a4df2b7fdec2be1426a > > Diff: https://reviews.apache.org/r/26720/diff/ > > > Testing > ------- > > Through a single trial on my workstation: > > Before this patch: > $ git clean -fdx > $ time ./gradlew build > /dev/null > real 2m2.406s > user 5m14.128s > sys 0m12.222s > > After this patch: > $ git clean -fdx > $ time ./gradlew build > /dev/null > real 1m30.926s > user 5m18.393s > sys 0m11.148s > > > Thanks, > > Bill Farner > > --===============2475786885769558110==--