Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 48BAC174CB for ; Wed, 15 Oct 2014 03:28:26 +0000 (UTC) Received: (qmail 88128 invoked by uid 500); 15 Oct 2014 03:28:26 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 88079 invoked by uid 500); 15 Oct 2014 03:28:25 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 88062 invoked by uid 99); 15 Oct 2014 03:28:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Oct 2014 03:28:25 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 15 Oct 2014 03:28:01 +0000 Received: (qmail 88012 invoked by uid 99); 15 Oct 2014 03:27:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Oct 2014 03:27:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3D0681DDFAC; Wed, 15 Oct 2014 03:27:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8242559206075116617==" MIME-Version: 1.0 Subject: Re: Review Request 26424: Disable requests http connection logging. From: "Joshua Cohen" To: "Bill Farner" , "Joe Smith" Cc: "Aurora" , "Joshua Cohen" Date: Wed, 15 Oct 2014 03:27:55 -0000 Message-ID: <20141015032755.24414.42518@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Joshua Cohen" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26424/ X-Sender: "Joshua Cohen" References: <20141015000217.24413.85684@reviews.apache.org> In-Reply-To: <20141015000217.24413.85684@reviews.apache.org> Reply-To: "Joshua Cohen" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8242559206075116617== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 15, 2014, 12:02 a.m., Bill Farner wrote: > > Sorry for the delay on this, i didn't realize i was on the hook to commit. > > > > Now on master: > > $ git log -1 > > commit 72fed752fcdbacf0f29e7eaef56c177f5ec9fcf0 > > Author: Joshua Cohen > > Date: Tue Oct 14 16:32:03 2014 -0700 > > > > Disable requests http connection logging. > > > > Bugs closed: AURORA-770 > > > > Reviewed at https://reviews.apache.org/r/26424/ D'oh, I had lost track of this, I thought it had already shipped :/. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/#review56610 ----------------------------------------------------------- On Oct. 8, 2014, 4:54 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26424/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2014, 4:54 p.m.) > > > Review request for Aurora, Joe Smith and Bill Farner. > > > Bugs: AURORA-770 > https://issues.apache.org/jira/browse/AURORA-770 > > > Repository: aurora > > > Description > ------- > > . > > > Diffs > ----- > > src/main/python/apache/aurora/common/transport.py 6f7c355d725b5e537cc4ae471170eaa8431da326 > src/test/python/apache/aurora/common/test_transport.py c722eae2d04dec90e9c772f49c578184a2bdf76c > > Diff: https://reviews.apache.org/r/26424/diff/ > > > Testing > ------- > > Added hokey test, ran hokey test. > > Also verified the lack of http connection logs when running client commands directly. > > > Thanks, > > Joshua Cohen > > --===============8242559206075116617==--