Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 84FF8175E2 for ; Tue, 14 Oct 2014 20:11:19 +0000 (UTC) Received: (qmail 11003 invoked by uid 500); 14 Oct 2014 20:11:19 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 10959 invoked by uid 500); 14 Oct 2014 20:11:19 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 10945 invoked by uid 99); 14 Oct 2014 20:11:19 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Oct 2014 20:11:19 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 14 Oct 2014 20:10:56 +0000 Received: (qmail 10744 invoked by uid 99); 14 Oct 2014 20:10:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Oct 2014 20:10:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 776BD1DDF4A; Tue, 14 Oct 2014 20:10:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3065794001099982966==" MIME-Version: 1.0 Subject: Re: Review Request 26430: Remove deprecated configuration options. From: "Zameer Manji" To: "Brian Wickman" , "Mark Chu-Carroll" , "Kevin Sweeney" Cc: "Aurora" , "Zameer Manji" Date: Tue, 14 Oct 2014 20:10:50 -0000 Message-ID: <20141014201050.24414.86894@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Zameer Manji" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26430/ X-Sender: "Zameer Manji" References: <20141008222944.24818.50374@reviews.apache.org> In-Reply-To: <20141008222944.24818.50374@reviews.apache.org> Reply-To: "Zameer Manji" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3065794001099982966== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26430/#review56565 ----------------------------------------------------------- Ping Pong - Zameer Manji On Oct. 8, 2014, 3:29 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26430/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2014, 3:29 p.m.) > > > Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman. > > > Bugs: AURORA-333 > https://issues.apache.org/jira/browse/AURORA-333 > > > Repository: aurora > > > Description > ------- > > This removes several long deprecated configuration options from aurora. > > The features removed are automatically filling out environment, cron_policy, daemon, health_check_interval_secs, recipes and the PackerObject. > > > Diffs > ----- > > docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 865742171c11fbe5cf1469a69dd7258ec1be28c2 > src/main/python/apache/aurora/client/binding_helper.py 6d6a06785c6840e4345e304eb4e242682676ac66 > src/main/python/apache/aurora/client/config.py e440f587d100ce46b2df85ccc663912c615051ef > src/main/python/apache/aurora/config/recipes.py 68b5d252f87a592d4c2f7d52525163829bea2cc9 > src/main/python/apache/aurora/config/schema/base.py f12634f103c3eb20e43f37c25d9b0fc3e3d228ec > src/main/python/apache/aurora/config/thrift.py 288fb40f65629c8fd4eb7d92c8bf02369237de3b > src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java ee9587582bd7c45a446e8afe28930c18a97d2792 > src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java d3c90416e48e25d83f28f966b21c018ee2a1ac27 > src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java cdd29ea2b6fc92b967571028d299260556e16d42 > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 > src/test/python/apache/aurora/client/api/test_scheduler_client.py 1835843f1795b0530874ec561582df17acfbce65 > src/test/python/apache/aurora/client/cli/util.py 967b5dcdab76f0581f6d2a518409c30de0800f27 > src/test/python/apache/aurora/client/commands/util.py 663f2f4a16113a36826943b7238cad900ae0dcd2 > src/test/python/apache/aurora/client/test_config.py 901c3378ed59c44b7e2dea239f186193f1f66355 > src/test/python/apache/aurora/config/test_thrift.py fd28313df2cfd5a9c7d00f6d329518b4caabacb2 > > Diff: https://reviews.apache.org/r/26430/diff/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > > Thanks, > > Zameer Manji > > --===============3065794001099982966==--