Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8DD2217884 for ; Tue, 14 Oct 2014 15:07:32 +0000 (UTC) Received: (qmail 43387 invoked by uid 500); 14 Oct 2014 15:07:32 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 43341 invoked by uid 500); 14 Oct 2014 15:07:32 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 43330 invoked by uid 99); 14 Oct 2014 15:07:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Oct 2014 15:07:31 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 14 Oct 2014 15:07:09 +0000 Received: (qmail 42626 invoked by uid 99); 14 Oct 2014 15:07:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Oct 2014 15:07:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 554641DDED0; Tue, 14 Oct 2014 15:07:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8847095757147030369==" MIME-Version: 1.0 Subject: Review Request 26688: Fix errors in help rendering: From: "Mark Chu-Carroll" To: "Joshua Cohen" , "David McLaughlin" Cc: "Aurora" , "Mark Chu-Carroll" Date: Tue, 14 Oct 2014 15:07:03 -0000 Message-ID: <20141014150703.24413.30380@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mark Chu-Carroll" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26688/ X-Sender: "Mark Chu-Carroll" Reply-To: "Mark Chu-Carroll" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8847095757147030369== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/ ----------------------------------------------------------- Review request for Aurora, David McLaughlin and Joshua Cohen. Bugs: aurora-831 https://issues.apache.org/jira/browse/aurora-831 Repository: aurora Description ------- - Put plugin-generated options into the correct order. - Include the option-name in the detailed help list. - Add missing metavars. Diffs ----- src/main/python/apache/aurora/client/cli/__init__.py da9d5b6ba4d22ba1f444341b97bbcfaf7889a4a8 src/main/python/apache/aurora/client/cli/options.py dc76c25b90acb9610e40b939e65c3cabf032649f src/main/python/apache/aurora/client/cli/standalone_client.py 20f4d7ef43ba336a2b6d02cbf5656c97bdfa2ea1 src/test/python/apache/aurora/client/cli/test_help.py f73c8a3778b7d118ea2865f213b442a607fb4a7d Diff: https://reviews.apache.org/r/26688/diff/ Testing ------- Thanks, Mark Chu-Carroll --===============8847095757147030369==--