Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 010CC17528 for ; Thu, 9 Oct 2014 00:46:30 +0000 (UTC) Received: (qmail 88492 invoked by uid 500); 9 Oct 2014 00:46:29 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 88447 invoked by uid 500); 9 Oct 2014 00:46:29 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 88430 invoked by uid 99); 9 Oct 2014 00:46:29 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Oct 2014 00:46:29 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 09 Oct 2014 00:46:06 +0000 Received: (qmail 88044 invoked by uid 99); 9 Oct 2014 00:46:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Oct 2014 00:46:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8D1A61DDD96; Thu, 9 Oct 2014 00:46:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9211841719833878783==" MIME-Version: 1.0 Subject: Re: Review Request 26383: Health Check Disabler From: "David Pan" To: "Joe Smith" , "Brian Wickman" , "Zameer Manji" Cc: "Joshua Cohen" , "Bill Farner" , "Aurora" , "David Pan" Date: Thu, 09 Oct 2014 00:46:00 -0000 Message-ID: <20141009004600.24817.2385@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "David Pan" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26383/ X-Sender: "David Pan" References: <20141009004329.24817.35178@reviews.apache.org> In-Reply-To: <20141009004329.24817.35178@reviews.apache.org> Reply-To: "David Pan" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============9211841719833878783== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/ ----------------------------------------------------------- (Updated Oct. 9, 2014, 12:46 a.m.) Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji. Repository: aurora Description (updated) ------- The health check disabler allows health checks for a job to be snoozed temporarily by touching a snooze file in the job's sandbox. The appropriate unit tests were modified/added. The corresponding JIRA ticket is the following: https://issues.apache.org/jira/browse/AURORA-795 Diffs ----- src/main/python/apache/aurora/executor/common/health_checker.py 4980411c847d12655cbb363404707ebd9f0bd163 src/test/python/apache/aurora/executor/common/BUILD c7f7a003c865d479ba6e3cd7b5349322f884f653 src/test/python/apache/aurora/executor/common/test_health_checker.py aa36415fa891fc523a3a376ffeca5d3cd5ceabec Diff: https://reviews.apache.org/r/26383/diff/ Testing ------- On vagrant in ~/aurora, I ran ./pants src/test/python/apache/aurora/executor:: Thanks, David Pan --===============9211841719833878783==--