Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6D0E617360 for ; Wed, 8 Oct 2014 23:51:25 +0000 (UTC) Received: (qmail 91778 invoked by uid 500); 8 Oct 2014 23:51:25 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 91733 invoked by uid 500); 8 Oct 2014 23:51:25 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 91722 invoked by uid 99); 8 Oct 2014 23:51:24 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Oct 2014 23:51:24 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 08 Oct 2014 23:51:02 +0000 Received: (qmail 91189 invoked by uid 99); 8 Oct 2014 23:50:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Oct 2014 23:50:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 19ABE1DDCE6; Wed, 8 Oct 2014 23:50:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8362133625647289924==" MIME-Version: 1.0 Subject: Re: Review Request 26464: Blacklist org/apache/aurora/scheduler/http/api/ApiBeta$2 which has no coverage. From: "Joshua Cohen" To: "Bill Farner" , "Joshua Cohen" Cc: "Aurora" , "Zameer Manji" Date: Wed, 08 Oct 2014 23:50:55 -0000 Message-ID: <20141008235055.15371.60226@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Joshua Cohen" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26464/ X-Sender: "Joshua Cohen" References: <20141008230938.24818.6603@reviews.apache.org> In-Reply-To: <20141008230938.24818.6603@reviews.apache.org> Reply-To: "Joshua Cohen" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8362133625647289924== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26464/#review55900 ----------------------------------------------------------- This doesn't actually fail when I run it locally. I'm worried that we're just fixing a symptom of the problem, and not the problem itself (i.e. we're going to be adding random classes to the legacy list despite their actually having coverage). - Joshua Cohen On Oct. 8, 2014, 11:09 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26464/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2014, 11:09 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-819 > https://issues.apache.org/jira/browse/AURORA-819 > > > Repository: aurora > > > Description > ------- > > The org/apache/aurora/scheduler/http/api/ApiBeta$2 class has no coverage so we blacklist it. > > > Diffs > ----- > > build.gradle 2e1bf78d7797f17afd51a94a22eff80e00aba464 > > Diff: https://reviews.apache.org/r/26464/diff/ > > > Testing > ------- > > ./gradlew clean build > > > Thanks, > > Zameer Manji > > --===============8362133625647289924==--