Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 209FC17254 for ; Wed, 8 Oct 2014 17:41:04 +0000 (UTC) Received: (qmail 54101 invoked by uid 500); 8 Oct 2014 17:41:04 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 54058 invoked by uid 500); 8 Oct 2014 17:41:04 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 54047 invoked by uid 99); 8 Oct 2014 17:41:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Oct 2014 17:41:03 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 08 Oct 2014 17:40:41 +0000 Received: (qmail 52998 invoked by uid 99); 8 Oct 2014 17:40:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Oct 2014 17:40:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F2A9C1DDD51; Wed, 8 Oct 2014 17:40:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0540043588504378792==" MIME-Version: 1.0 Subject: Re: Review Request 26448: Move the error-log seed file to a user specified directory. From: "David McLaughlin" To: "Zameer Manji" , "David McLaughlin" Cc: "Mark Chu-Carroll" , "Aurora" Date: Wed, 08 Oct 2014 17:40:34 -0000 Message-ID: <20141008174034.24817.12737@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "David McLaughlin" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26448/ X-Sender: "David McLaughlin" References: <20141008173215.24817.50768@reviews.apache.org> In-Reply-To: <20141008173215.24817.50768@reviews.apache.org> Reply-To: "David McLaughlin" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0540043588504378792== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26448/#review55837 ----------------------------------------------------------- Ship it! Ship It! - David McLaughlin On Oct. 8, 2014, 5:32 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26448/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2014, 5:32 p.m.) > > > Review request for Aurora, David McLaughlin and Zameer Manji. > > > Bugs: aurora-779 > https://issues.apache.org/jira/browse/aurora-779 > > > Repository: aurora > > > Description > ------- > > Instead of dumping error traces into the users current directory, > dump them into a user specified directory, with a benign default. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/__init__.py 5c0688f5ea184e2c0b1f8e1b54a109d8260a12fa > src/main/python/apache/aurora/client/cli/standalone_client.py 4fdcf6df493f63aae672e0834214dad208cf4110 > src/test/python/apache/aurora/client/cli/test_create.py 8dc0ccb78539f8b0c7829ec2927da93d4afa9ada > src/test/python/apache/aurora/client/cli/test_inspect.py fd35fe0185c1850910bd18d6a1e5831cd3effa6f > src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a > src/test/python/apache/aurora/client/cli/util.py ff7eda20dbba073c8b24fbe3f4389292aab2d128 > > Diff: https://reviews.apache.org/r/26448/diff/ > > > Testing > ------- > > Added new unit test; verified all tests pass. > > > Thanks, > > Mark Chu-Carroll > > --===============0540043588504378792==--