Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 41AFE171D9 for ; Tue, 7 Oct 2014 21:19:14 +0000 (UTC) Received: (qmail 84806 invoked by uid 500); 7 Oct 2014 21:19:14 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 84765 invoked by uid 500); 7 Oct 2014 21:19:14 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 84753 invoked by uid 99); 7 Oct 2014 21:19:13 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Oct 2014 21:19:13 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 07 Oct 2014 21:18:50 +0000 Received: (qmail 84428 invoked by uid 99); 7 Oct 2014 21:18:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Oct 2014 21:18:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EFB621DDD11; Tue, 7 Oct 2014 21:18:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3793669182239191697==" MIME-Version: 1.0 Subject: Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test. From: "Kevin Sweeney" To: "Mark Chu-Carroll" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" Date: Tue, 07 Oct 2014 21:18:43 -0000 Message-ID: <20141007211843.24817.18192@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26308/ X-Sender: "Kevin Sweeney" References: <20141004175528.19177.54156@reviews.apache.org> In-Reply-To: <20141004175528.19177.54156@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3793669182239191697== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55712 ----------------------------------------------------------- src/test/python/apache/aurora/client/cli/test_api_from_cli.py Why do these need to be mocks? This would work identically using the Thrift structures directly. If you want to prevent setting a field that doesn't exist you can use the constructor kwargs form of the thrift object, i.e. ```py task = ScheduledTask( key=JobKey(role=..., ...), assignedTask=AssignedTask( slaveHost=..., ... ), ... ) ``` - Kevin Sweeney On Oct. 4, 2014, 10:55 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26308/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2014, 10:55 a.m.) > > > Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll. > > > Repository: aurora > > > Description > ------- > > Fixes two problems: > > - mocking was incorrect in `test_status_api_failure`. Turns out that Mock objects were being passed around and somehow resulted in the test case passing. > - use of `threading.Event()` was broken in scheduler_client.py. I don't think it's possible to enter those branches. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/__init__.py 26300792594e4005dacc139a9f89711b8a66ab61 > src/main/python/apache/aurora/client/api/command_runner.py a1fed5fc75dde3a79c840515e6daa4741156ef97 > src/main/python/apache/aurora/client/api/job_monitor.py 18d5c0381d43fc7b24bae4b2e5e6fdc774a74b52 > src/main/python/apache/aurora/client/api/scheduler_client.py 311c954f1db245b75192d00c6aca0721085fbf32 > src/main/python/apache/aurora/client/api/updater.py bf608981c2f2e7960b68c3fbda144277a59a3d40 > src/main/python/apache/aurora/common/aurora_job_key.py a7ca7b6df6b9566b3ce617283ccac948deb2eb83 > src/test/python/apache/aurora/client/api/test_job_monitor.py 5b26539f86a0a82f72753a803a769eda77cbc332 > src/test/python/apache/aurora/client/api/test_scheduler_client.py 1835843f1795b0530874ec561582df17acfbce65 > src/test/python/apache/aurora/client/api/test_updater.py 6905831b23a84320e7f41843efd62b86da366c0b > src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 > src/test/python/apache/aurora/client/cli/test_cancel_update.py c15e142930c9474c7873dd931261b6ab4eb5967f > src/test/python/apache/aurora/client/cli/test_command_hooks.py 3acd2ba0d8bd8c71d4c0a9d71a035fc974fa20c3 > src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3 > src/test/python/apache/aurora/client/cli/test_diff.py e1a6f764830e06c73d0bc10a3b5da67219da836c > src/test/python/apache/aurora/client/cli/test_kill.py e3a366bf67074e50787394cad58d5e01359b641e > src/test/python/apache/aurora/client/cli/test_logging.py 6285fbb07442291c2dc4096e68eb285c98994097 > src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a > src/test/python/apache/aurora/client/cli/test_status.py bd30b11022ee0d1fb38da9f6efd4d9c5923b7d13 > src/test/python/apache/aurora/client/cli/test_task_run.py 1ce9a632874e818eee71573cd481842affae3615 > src/test/python/apache/aurora/client/cli/test_update.py 85b1db19d89967a741bfba7964eeb368426f0b61 > src/test/python/apache/aurora/client/commands/test_admin.py 1192556c027dc3adf16bb37adeac7798cf9ef93d > src/test/python/apache/aurora/client/commands/test_cancel_update.py 5f05ef7c0643d189de3de38c75aae58c2a3814a4 > src/test/python/apache/aurora/client/commands/test_create.py 7503345ea1c0f224a894ce02cc2c2d8719574e32 > src/test/python/apache/aurora/client/commands/test_diff.py 8f5da7d2bca9b0486b635afe49d3885151624e12 > src/test/python/apache/aurora/client/commands/test_hooks.py 0861f13b13a8406950ba953efba0ffae186a8253 > src/test/python/apache/aurora/client/commands/test_kill.py c0a6fd44c5691cde50746ffdec325bb11a33469a > src/test/python/apache/aurora/client/commands/test_run.py e97b5156609f80a4170028e780bcd891e56983ff > src/test/python/apache/aurora/client/commands/test_ssh.py c5ca66e378bfc97c40a406a758ae4dfaef8ab2c8 > src/test/python/apache/aurora/client/commands/test_status.py bda1f28d544ae48428129f8167d8632ef27f5fba > src/test/python/apache/aurora/client/commands/test_update.py af2cbc7f88287201a472ba36902b00d90bc77d3b > > Diff: https://reviews.apache.org/r/26308/diff/ > > > Testing > ------- > > ./pants src/test/python:all -vxs > > > Thanks, > > Bill Farner > > --===============3793669182239191697==--