Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C4D6717563 for ; Tue, 7 Oct 2014 17:22:28 +0000 (UTC) Received: (qmail 85985 invoked by uid 500); 7 Oct 2014 17:22:28 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 85944 invoked by uid 500); 7 Oct 2014 17:22:28 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 85933 invoked by uid 99); 7 Oct 2014 17:22:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Oct 2014 17:22:28 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 07 Oct 2014 17:22:26 +0000 Received: (qmail 83637 invoked by uid 99); 7 Oct 2014 17:22:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Oct 2014 17:22:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 176BE1DDCD1; Tue, 7 Oct 2014 17:22:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1817895948962307545==" MIME-Version: 1.0 Subject: Re: Review Request 26417: Change JSON result of "job status" when job isn't found. From: "David McLaughlin" To: "Zameer Manji" , "David McLaughlin" Cc: "Mark Chu-Carroll" , "Aurora" Date: Tue, 07 Oct 2014 17:22:03 -0000 Message-ID: <20141007172203.15371.18245@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "David McLaughlin" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26417/ X-Sender: "David McLaughlin" References: <20141007171219.15371.63035@reviews.apache.org> In-Reply-To: <20141007171219.15371.63035@reviews.apache.org> Reply-To: "David McLaughlin" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============1817895948962307545== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/#review55663 ----------------------------------------------------------- Ship it! Ship It! - David McLaughlin On Oct. 7, 2014, 5:12 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26417/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2014, 5:12 p.m.) > > > Review request for Aurora, David McLaughlin and Zameer Manji. > > > Bugs: aurora-803 > https://issues.apache.org/jira/browse/aurora-803 > > > Repository: aurora > > > Description > ------- > > Instead of just exiting with an error code, return a valid JSON > structure when a user calls "aurora job status", and no job matching > the jobspec is running. > > Also, remove a bunch of "pants" labels from build files, which generated > warnings while building the tests. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/context.py 0816ac02846c30e0beab5c0339aca38f15c4ae10 > src/main/python/apache/aurora/client/cli/jobs.py 103fb53cb5101d3e025d8712e3887bccdfbb6aeb > src/test/python/apache/aurora/client/cli/BUILD 8ce6bd5b7faa1579372fb6935180ea982af64af8 > src/test/python/apache/aurora/client/cli/test_status.py bd30b11022ee0d1fb38da9f6efd4d9c5923b7d13 > > Diff: https://reviews.apache.org/r/26417/diff/ > > > Testing > ------- > > Ran all unit tests; added new test for the empty job list json case. > > > Thanks, > > Mark Chu-Carroll > > --===============1817895948962307545==--