Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5549617A77 for ; Mon, 6 Oct 2014 23:31:24 +0000 (UTC) Received: (qmail 42146 invoked by uid 500); 6 Oct 2014 23:31:24 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 42104 invoked by uid 500); 6 Oct 2014 23:31:24 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 42093 invoked by uid 99); 6 Oct 2014 23:31:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Oct 2014 23:31:23 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 06 Oct 2014 23:31:22 +0000 Received: (qmail 41866 invoked by uid 99); 6 Oct 2014 23:31:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Oct 2014 23:31:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7BA0E1DDCD2; Mon, 6 Oct 2014 23:30:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0609488720303670352==" MIME-Version: 1.0 Subject: Re: Review Request 26391: Remove special casing of 'rack' attribute. From: "Maxim Khutornenko" To: "Bill Farner" , "Maxim Khutornenko" Cc: "Aurora" , "Zameer Manji" Date: Mon, 06 Oct 2014 23:30:58 -0000 Message-ID: <20141006233058.24817.21676@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26391/ X-Sender: "Maxim Khutornenko" References: <20141006232132.24817.46026@reviews.apache.org> In-Reply-To: <20141006232132.24817.46026@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0609488720303670352== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26391/#review55606 ----------------------------------------------------------- Ship it! Ship It! - Maxim Khutornenko On Oct. 6, 2014, 11:21 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26391/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 11:21 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-662 > https://issues.apache.org/jira/browse/AURORA-662 > > > Repository: aurora > > > Description > ------- > > This patch removes the auto injection of the 'rack' attribute in the constraint of every job. This will allow for jobs without the 'rack' attribute to be scheduled and allow Aurora to schedule jobs on Mesos slaves that don't have the 'rack' attribute. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 865742171c11fbe5cf1469a69dd7258ec1be28c2 > src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java 9ee4fe2e76d36e17f8de2ab3eb714a6aae52c09c > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 > > Diff: https://reviews.apache.org/r/26391/diff/ > > > Testing > ------- > > ./gradlew clean build -Pq > > > Thanks, > > Zameer Manji > > --===============0609488720303670352==--