Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EC906179AF for ; Mon, 6 Oct 2014 18:22:05 +0000 (UTC) Received: (qmail 88440 invoked by uid 500); 6 Oct 2014 18:22:05 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 88398 invoked by uid 500); 6 Oct 2014 18:22:05 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 88387 invoked by uid 99); 6 Oct 2014 18:22:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Oct 2014 18:22:05 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 06 Oct 2014 18:22:03 +0000 Received: (qmail 88142 invoked by uid 99); 6 Oct 2014 18:21:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Oct 2014 18:21:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BC8CF1DDCC9; Mon, 6 Oct 2014 18:21:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7245999127023716157==" MIME-Version: 1.0 Subject: Re: Review Request 26372: Test all the nouns and verbs within the Aurora Command Line for help output From: "David McLaughlin" To: "Mark Chu-Carroll" , "Zameer Manji" , "David McLaughlin" Cc: "Aurora" , "Joe Smith" Date: Mon, 06 Oct 2014 18:21:39 -0000 Message-ID: <20141006182139.20120.94038@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "David McLaughlin" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26372/ X-Sender: "David McLaughlin" References: <20141006165838.12762.7642@reviews.apache.org> In-Reply-To: <20141006165838.12762.7642@reviews.apache.org> Reply-To: "David McLaughlin" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============7245999127023716157== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26372/#review55544 ----------------------------------------------------------- Pushed to master, feel free to close this out. - David McLaughlin On Oct. 6, 2014, 4:58 p.m., Joe Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26372/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 4:58 p.m.) > > > Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Zameer Manji. > > > Bugs: AURORA-748 > https://issues.apache.org/jira/browse/AURORA-748 > > > Repository: aurora > > > Description > ------- > > This steps through each noun within the commandline, and each verb attached to those nouns to validate help output appears as expected. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9 > src/test/python/apache/aurora/client/cli/test_help.py e1602b145a6b100efca8663104a7d44cc119c5a5 > > Diff: https://reviews.apache.org/r/26372/diff/ > > > Testing > ------- > > [tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants ./src/test/python/apache/aurora/client/cli:help > Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD, help)]) > ==================================================================================================================================================== test session starts ===================================================================================================================================================== > platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3 > plugins: cov, timeout > collected 6 items > > src/test/python/apache/aurora/client/cli/test_help.py ...... > > ================================================================================================================================================== 6 passed in 0.71 seconds ================================================================================================================================================== > src.test.python.apache.aurora.client.cli.help ..... SUCCESS > > > And confirmed via: > > > [tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ git diff > diff --git a/src/main/python/apache/aurora/client/cli/update.py b/src/main/python/apache/aurora/client/cli/update.py > index 41475a7..142ba5e 100644 > --- a/src/main/python/apache/aurora/client/cli/update.py > +++ b/src/main/python/apache/aurora/client/cli/update.py > @@ -42,7 +42,7 @@ class StartUpdate(Verb): > INSTANCES_SPEC_ARGUMENT, CONFIG_ARGUMENT > ] > > - @property > + #@property > def help(self): > return textwrap.dedent("""\ > Start a scheduler-driven rolling upgrade on a running job, using the update > [tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants ./src/test/python/apache/aurora/client/cli:help > Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD, help)]) > ==================================================================================================================================================== test session starts ===================================================================================================================================================== > platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3 > plugins: cov, timeout > collected 6 items > > src/test/python/apache/aurora/client/cli/test_help.py F..... > > ========================================================================================================================================================== FAILURES ========================================================================================================================================================== > ___________________________________________________________________________________________________________________________________________________ TestHelp.test_all_help ___________________________________________________________________________________________________________________________________________________ > > self = > > def test_all_help(self): > for noun in self.cmd.registered_nouns: > with patch('apache.aurora.client.cli.client.AuroraCommandLine.print_out', > side_effect=self.mock_print): > self.cmd.execute(['help', noun]) > assert 'Usage for noun "%s":' % noun in self.transcript > assert self.err_transcript == [] > self.transcript = [] > for verb in self.cmd.nouns.get(noun).verbs.keys(): > self.cmd.execute(['help', noun, verb]) > > assert 'Usage for verb "%s %s":' % (noun, verb) in self.transcript > E AssertionError: assert ('Usage for verb "%s %s":' % ('beta-update', 'start')) in [] > E + where [] = .transcript > > src/test/python/apache/aurora/client/cli/test_help.py:50: AssertionError > ---------------------------------------------------------------------------------------------------------------------------------------------------- Captured stderr call ---------------------------------------------------------------------------------------------------------------------------------------------------- > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > log(ERROR): Unknown error: sequence item 24: expected string, instancemethod found > ============================================================================================================================================= 1 failed, 5 passed in 0.88 seconds ============================================================================================================================================= > src.test.python.apache.aurora.client.cli.help ..... FAILURE > > > Thanks, > > Joe Smith > > --===============7245999127023716157==--