Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0124017E80 for ; Fri, 3 Oct 2014 02:51:22 +0000 (UTC) Received: (qmail 41969 invoked by uid 500); 3 Oct 2014 02:51:21 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 41923 invoked by uid 500); 3 Oct 2014 02:51:21 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 41908 invoked by uid 99); 3 Oct 2014 02:51:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Oct 2014 02:51:21 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 03 Oct 2014 02:50:54 +0000 Received: (qmail 36737 invoked by uid 99); 3 Oct 2014 02:50:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Oct 2014 02:50:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7BE901DDC1F; Fri, 3 Oct 2014 02:50:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8430371539692651648==" MIME-Version: 1.0 Subject: Re: Review Request 26300: Don't kill GC Executor after period of inactivity From: "Ben Mahler" To: "Vinod Kone" , "Ben Mahler" , "Brian Wickman" Cc: "Aurora" , "Kevin Sweeney" Date: Fri, 03 Oct 2014 02:50:48 -0000 Message-ID: <20141003025048.19177.55255@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26300/ X-Sender: "Ben Mahler" References: <20141003015950.18846.29357@reviews.apache.org> In-Reply-To: <20141003015950.18846.29357@reviews.apache.org> Reply-To: "Ben Mahler" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8430371539692651648== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26300/#review55318 ----------------------------------------------------------- Thanks Kevin! Looks good to me, will defer to wickman for a Ship It. - Ben Mahler On Oct. 3, 2014, 1:59 a.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26300/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2014, 1:59 a.m.) > > > Review request for Aurora, Ben Mahler, Vinod Kone, and Brian Wickman. > > > Bugs: AURORA-788 > https://issues.apache.org/jira/browse/AURORA-788 > > > Repository: aurora > > > Description > ------- > > The GC executor is configured to exit after 15 minutes of inactivity. This leads to a race where the mesos slave gets a launchTask message for a GC executor just as the executor has exited, causing TASK_LOST noise. This also increases the risk that a slave will lose its GC executor due to the scheduler not being able to find a slot for it (since GC executors will have a higher churn rate). > > Cluster operators will still be able to deploy new versions of the GC executor as the 24-hour max lifetime limit is still in place. This patch only removes the inactivity limit. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/gc_executor.py 44eb0da984a126536f0d277da3da128089201a47 > src/test/python/apache/aurora/executor/test_gc_executor.py 774c9ba0d5c31fc4c46dbe257579e013460fa943 > > Diff: https://reviews.apache.org/r/26300/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/executor:gc_executor > > > Thanks, > > Kevin Sweeney > > --===============8430371539692651648==--