Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2F03A178E6 for ; Wed, 1 Oct 2014 18:19:35 +0000 (UTC) Received: (qmail 35262 invoked by uid 500); 1 Oct 2014 18:19:35 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 35217 invoked by uid 500); 1 Oct 2014 18:19:35 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 35203 invoked by uid 99); 1 Oct 2014 18:19:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Oct 2014 18:19:34 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 01 Oct 2014 18:19:12 +0000 Received: (qmail 34207 invoked by uid 99); 1 Oct 2014 18:19:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Oct 2014 18:19:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 88CF81DDA92; Wed, 1 Oct 2014 18:19:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4475947190630205371==" MIME-Version: 1.0 Subject: Re: Review Request 26233: Add a monitoring guide. From: "Kevin Sweeney" To: "Maxim Khutornenko" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" Date: Wed, 01 Oct 2014 18:19:06 -0000 Message-ID: <20141001181906.18846.51525@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26233/ X-Sender: "Kevin Sweeney" References: <20141001174130.18846.5279@reviews.apache.org> In-Reply-To: <20141001174130.18846.5279@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4475947190630205371== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 1, 2014, 10:41 a.m., Kevin Sweeney wrote: > > docs/monitoring.md, line 184 > > > > > > style point: we've rendered command-line flags with a single dash in other documentation. Though both are acceptable it would be good to internally standardize on one style. > > Bill Farner wrote: > Thanks, this isn't even a style point as much as a bad doc. The command line parser requires a single dash here. Fixed. aha, tmyk - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26233/#review55089 ----------------------------------------------------------- On Oct. 1, 2014, 10:56 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26233/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2014, 10:56 a.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-634 > https://issues.apache.org/jira/browse/AURORA-634 > > > Repository: aurora > > > Description > ------- > > Add a monitoring guide. > > > Diffs > ----- > > docs/deploying-aurora-scheduler.md 9b6d526b22f2e39dfe95f494720f550d0b67d176 > docs/monitoring.md PRE-CREATION > > Diff: https://reviews.apache.org/r/26233/diff/ > > > Testing > ------- > > Rendered here: https://github.com/wfarner/incubator-aurora/blob/wfarner/monitoring_guide/docs/monitoring.md > > I'm not terribly happy about the organization at the bottom, specifically the wrapping of rate ratio. Happy to rework if anybody has a suggestion. > > > Thanks, > > Bill Farner > > --===============4475947190630205371==--