Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AC38017FE1 for ; Wed, 1 Oct 2014 00:18:28 +0000 (UTC) Received: (qmail 80698 invoked by uid 500); 1 Oct 2014 00:18:28 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 80652 invoked by uid 500); 1 Oct 2014 00:18:28 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 80640 invoked by uid 99); 1 Oct 2014 00:18:27 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Oct 2014 00:18:27 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 01 Oct 2014 00:18:05 +0000 Received: (qmail 80537 invoked by uid 99); 1 Oct 2014 00:18:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Oct 2014 00:18:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5DF671DDBA0; Wed, 1 Oct 2014 00:18:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7620874802373714811==" MIME-Version: 1.0 Subject: Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor. From: "Zameer Manji" To: "Bill Farner" , "Brian Wickman" , "Kevin Sweeney" Cc: "Aurora" , "Zameer Manji" Date: Wed, 01 Oct 2014 00:18:00 -0000 Message-ID: <20141001001800.19177.70876@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Zameer Manji" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/25974/ X-Sender: "Zameer Manji" References: <20140930005426.18846.86190@reviews.apache.org> In-Reply-To: <20140930005426.18846.86190@reviews.apache.org> Reply-To: "Zameer Manji" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============7620874802373714811== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ ----------------------------------------------------------- (Updated Sept. 30, 2014, 5:17 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Changes ------- Brian's Feedback. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description ------- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs (updated) ----- src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing (updated) ------- ./pants src/test/python/apache/aurora/executor:executor-small ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji --===============7620874802373714811==--