aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@twopensource.com>
Subject Re: Review Request 27375: Remove dependency on application-http.
Date Thu, 30 Oct 2014 09:49:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27375/#review59162
-----------------------------------------------------------

Ship it!


One down...


src/test/java/org/apache/aurora/scheduler/http/QuitCallbackTest.java
<https://reviews.apache.org/r/27375/#comment100471>

    Maybe nitpicky, but should the behavior under test here be that Lifecycle#shutdown is
invoked, rather than that Lifecycle will execute the command when shutdown is called? I.e.,
instead of setting up a QuitCallback with a real Lifecycle that's given a mock Command, just
set it up with a mock Lifecycle and assert that shutdown is called? The former relies on knowledge
of what Lifecycle does on shutdown which seems out of scope for this test.


- Joshua Cohen


On Oct. 30, 2014, 6:02 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27375/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 6:02 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> We were only using this for DefaultQuitHandler, which is easy enough to replace.
> 
> Additionally, common:io is only used in tests.
> 
> 
> Diffs
> -----
> 
>   build.gradle 719ceb75aa462a7e3d0f06602facdd866f18ee5d 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 958f60c9d804af4c915a53ccdaf489a91ee284c7

>   src/main/java/org/apache/aurora/scheduler/http/QuitCallback.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/http/QuitCallbackTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27375/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message