aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 27289: Fixing error reporting in v1 client updater.
Date Tue, 28 Oct 2014 20:47:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27289/#review58862
-----------------------------------------------------------

Ship it!



src/main/python/apache/aurora/client/api/updater.py
<https://reviews.apache.org/r/27289/#comment100014>

    What is "the deprecation"?  Can you point to a ticket?


- Bill Farner


On Oct. 28, 2014, 8:41 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27289/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 8:41 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-901
>     https://issues.apache.org/jira/browse/AURORA-901
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The v1 base.py is not using a new `details` field to format error message.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/BUILD 5787175f9caa73925fcf08fcc63bee519c1e9701

>   src/main/python/apache/aurora/client/api/updater.py 2e6bc9fdc1c745b2a69f8929209d46517c218700

>   src/main/python/apache/aurora/client/base.py 0c8e97e0b26b0c4ede77873eaae76ebe7bf36a4a

>   src/test/python/apache/aurora/client/BUILD 170227c786039a31d1478429798169053c6fda14

>   src/test/python/apache/aurora/client/api/test_updater.py f0e45e3f33de0dcb87251021bbf96bfea6f38ea8

>   src/test/python/apache/aurora/client/commands/util.py 65a358acea1fc7532e7d25c9b613134b67d110a1

>   src/test/python/apache/aurora/client/test_base.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27289/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message