aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 27182: Add a test for the thermos resource module
Date Mon, 27 Oct 2014 19:46:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review58668
-----------------------------------------------------------



src/test/python/apache/thermos/monitoring/test_resource.py
<https://reviews.apache.org/r/27182/#comment99741>

    patching a private method assumes intimate knowledge of the class under test and suggests
refactoring


- Kevin Sweeney


On Oct. 24, 2014, 5:12 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27182/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 5:12 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a test for the thermos resource module
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/monitoring/monitor.py 8f87f5ffc39c87e87ff78b941ea30df7138bd1ef

>   src/test/python/apache/thermos/monitoring/BUILD 33d6bba43aff6d62b2646491f004475c27ed99db

>   src/test/python/apache/thermos/monitoring/test_resource.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27182/diff/
> 
> 
> Testing
> -------
> 
> [tw-mbp13-jsmith aurora (yasumoto/psutil_2.1.3)]$ ./pants ./src/test/python/apache/thermos/monitoring:test_resource
> Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/thermos/monitoring/BUILD,
test_resource)])
> ====================================================================================================================================================
test session starts =====================================================================================================================================================
> platform darwin -- Python 2.7.6 -- py-1.4.26 -- pytest-2.6.4
> plugins: cov, timeout
> collected 5 items 
> 
> src/test/python/apache/thermos/monitoring/test_resource.py .....
> 
> ==================================================================================================================================================
5 passed in 0.21 seconds ==================================================================================================================================================
> src.test.python.apache.thermos.monitoring.test_resource                         .....
  SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message