aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 27145: Add a script that publishes build results to review board.
Date Fri, 24 Oct 2014 21:33:13 GMT


> On Oct. 24, 2014, 8:06 p.m., Kevin Sweeney wrote:
> > build-support/jenkins/review_feedback.py, line 39
> > <https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line39>
> >
> >     Use print() as a function, here and throughout

Done.


> On Oct. 24, 2014, 8:06 p.m., Kevin Sweeney wrote:
> > build-support/jenkins/review_feedback.py, line 94
> > <https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line94>
> >
> >     as we're on python2.7 you can use argparse now (which removes some boilerplate
and gives nicer errors)

Thanks, done.


> On Oct. 24, 2014, 8:06 p.m., Kevin Sweeney wrote:
> > build-support/jenkins/review_feedback.py, line 97
> > <https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line97>
> >
> >     read this from a file? argparse makes this easy

Sure, done.


> On Oct. 24, 2014, 8:06 p.m., Kevin Sweeney wrote:
> > build-support/jenkins/review_feedback.py, line 116
> > <https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line116>
> >
> >     with argparse you can just do required=True

Done, thanks again.


> On Oct. 24, 2014, 8:06 p.m., Kevin Sweeney wrote:
> > build-support/jenkins/review_feedback.py, line 149
> > <https://reviews.apache.org/r/27145/diff/1/?file=732311#file732311line149>
> >
> >     Would the correct Apache exclaimation be +1 here?

Sure, done.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/#review58338
-----------------------------------------------------------


On Oct. 24, 2014, 5:32 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27145/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 5:32 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-883
>     https://issues.apache.org/jira/browse/AURORA-883
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I also removed `--stacktrace` from the gradle command.  This makes for better tail output.
 I originally added `--stacktrace` to help debug build flakiness we were having due to jenkins
machine configuration (but haven't had in a very long time): https://reviews.apache.org/r/23776/
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 
>   build-support/jenkins/review_feedback.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27145/diff/
> 
> 
> Testing
> -------
> 
> I've run this a handful of times on my workstation, it seems to be doing its job.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message