aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 27145: Add a script that publishes build results to review board.
Date Fri, 24 Oct 2014 20:06:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27145/#review58338
-----------------------------------------------------------

Ship it!



build-support/jenkins/review_feedback.py
<https://reviews.apache.org/r/27145/#comment99294>

    Use print() as a function, here and throughout



build-support/jenkins/review_feedback.py
<https://reviews.apache.org/r/27145/#comment99290>

    as we're on python2.7 you can use argparse now (which removes some boilerplate and gives
nicer errors)



build-support/jenkins/review_feedback.py
<https://reviews.apache.org/r/27145/#comment99289>

    read this from a file? argparse makes this easy



build-support/jenkins/review_feedback.py
<https://reviews.apache.org/r/27145/#comment99291>

    with argparse you can just do required=True



build-support/jenkins/review_feedback.py
<https://reviews.apache.org/r/27145/#comment99288>

    Would the correct Apache exclaimation be +1 here?


- Kevin Sweeney


On Oct. 24, 2014, 10:32 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27145/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 10:32 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-883
>     https://issues.apache.org/jira/browse/AURORA-883
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I also removed `--stacktrace` from the gradle command.  This makes for better tail output.
 I originally added `--stacktrace` to help debug build flakiness we were having due to jenkins
machine configuration (but haven't had in a very long time): https://reviews.apache.org/r/23776/
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 
>   build-support/jenkins/review_feedback.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27145/diff/
> 
> 
> Testing
> -------
> 
> I've run this a handful of times on my workstation, it seems to be doing its job.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message