aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 26845: Adding Aurora scheduler storage doc.
Date Fri, 24 Oct 2014 00:52:53 GMT


> On Oct. 17, 2014, 3:19 p.m., Jay Buffington wrote:
> > docs/storage.md, line 16
> > <https://reviews.apache.org/r/26845/diff/2/?file=723856#file723856line16>
> >
> >     I haven't really looked at the update features, yet.  Is this live and ready
to go?  If not maybe defer referencing this until the updater work is shipped?

Yes, it's in beta and is available under "aurora beta-update" in the client.


> On Oct. 17, 2014, 3:19 p.m., Jay Buffington wrote:
> > docs/storage.md, line 18
> > <https://reviews.apache.org/r/26845/diff/2/?file=723856#file723856line18>
> >
> >     This is pretty much the complete list of what is stored in the replicated log,
right?  s/For Example/Aurora stores the follow data/

Not, really. There are other stores handling job locks and scheduler internal data (i.e. framework
ID) that are insignificant for explicit mentioning.


> On Oct. 17, 2014, 3:19 p.m., Jay Buffington wrote:
> > docs/storage.md, line 36
> > <https://reviews.apache.org/r/26845/diff/2/?file=723856#file723856line36>
> >
> >     Link to your doc that describes how to config and recover backups.  When I read
this I immediatly want to know how often the snapshots are taken and what negative impact
there is from taking snapshots too frequently.

It was not available at the time of writing :), will make sure to add it.


> On Oct. 17, 2014, 3:19 p.m., Jay Buffington wrote:
> > docs/storage.md, line 11
> > <https://reviews.apache.org/r/26845/diff/2/?file=723856#file723856line11>
> >
> >     I'd like the see a paragraphic justifying avoiding the more traditional approaching
of writing this data to a database like mysql or cassandra.  I think the justification is
to remove deployment dependencies?

That and the high availability of a distributed storage. However, I'd avoid adding any comparative
analysis here as we are currently re-evaluating our options ;)


> On Oct. 17, 2014, 3:19 p.m., Jay Buffington wrote:
> > docs/storage.md, line 40
> > <https://reviews.apache.org/r/26845/diff/2/?file=723856#file723856line40>
> >
> >     The ellipses serve no purpose. I'd remove them, but this is a minor knit.

Dropped.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26845/#review57143
-----------------------------------------------------------


On Oct. 17, 2014, 12:21 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26845/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 12:21 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-839
>     https://issues.apache.org/jira/browse/AURORA-839
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Created a high level storage architecture write up.
> 
> 
> Diffs
> -----
> 
>   docs/images/storage_hierarchy.png PRE-CREATION 
>   docs/storage.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26845/diff/
> 
> 
> Testing
> -------
> 
> https://github.com/maxim111333/incubator-aurora/blob/storage_doc/docs/storage.md
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message