aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@twopensource.com>
Subject Re: Review Request 27044: Make executor overhead configurable
Date Thu, 23 Oct 2014 22:56:09 GMT


> On Oct. 22, 2014, 5:32 p.m., Joshua Cohen wrote:
> > src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java, line 67
> > <https://reviews.apache.org/r/27044/diff/1/?file=728781#file728781line67>
> >
> >     Do we actually need to use a ResourceSlotFactory here? The usage seems to be
entirely internal to the test. We could just use constants?
> 
> Zameer Manji wrote:
>     We need the slot factory to create the task factory in this test.

derp, missed that.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/#review57825
-----------------------------------------------------------


On Oct. 22, 2014, 4:57 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27044/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 4:57 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-830
>     https://issues.apache.org/jira/browse/AURORA-830
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This patch changes the scheduler such that the executor overhead can be configured from
the commandline.
> 
> 
> Diffs
> -----
> 
>   config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
>   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c

>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f

>   src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 048740953629a950c136179c9b880b8dce8fa932

>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java e9f251508257cd7287ff00773e0073a3cd130df8

>   src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 283f7e1e22decfe1053bd5640e8283b40eeac592

>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e3018e8c740ff322e0809ac2995121aa7d9b6d4

>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java da29428adaebcb27b20a10a8c6b7e380662fce4a

>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 4db9be86f2e7db08d12e0182914a7c5130301b13

>   src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594

>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java c405d4c8b127c2dd7054c9520064da0346690f02

>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 8ee84cda8670d117e2efa2d1a114da6f0d8315d6

>   src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
4065629e9d488b122aa811b9802def0b51a21294 
>   src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 6a9c4ee278ed3ee8222404504e571f20991c2ae2

>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java c48cbae4864127e7799917182439f7670285b0d3

> 
> Diff: https://reviews.apache.org/r/27044/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message